Mbaluda test perf#1150
Merged
Merged
Conversation
|
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a few shared C/C++ CodeQL libraries/queries, seemingly to improve query evaluation performance and to align dataflow usage with the newer semmle.code.cpp.dataflow.new modules, while also correcting the EXP50-CPP alert message text and regenerating the corresponding expected test output.
Changes:
- Switched a taint-tracking helper in
STLContainers.qllfrompragma[noinline, nomagic]topragma[inline]. - Updated
SideEffect.qllto importsemmle.code.cpp.dataflow.new.DataFlowinstead of the legacyDataFlow. - Fixed the EXP50-CPP message wording (“unsequenced relative to…”) and updated the
.expectedfile accordingly.
Checklist items not satisfied / uncertain (per repo guidelines):
- A change note appears required (performance/results-impacting changes), but no
change_notes/YYYY-MM-DD-*.mdentry is included in the provided diff.
Show a summary per file
| File | Description |
|---|---|
| cpp/common/src/codingstandards/cpp/standardlibrary/STLContainers.qll | Changes pragma settings on a local taint predicate (likely performance-related). |
| cpp/common/src/codingstandards/cpp/SideEffect.qll | Migrates a private dataflow import to semmle.code.cpp.dataflow.new.DataFlow. |
| cpp/cert/src/rules/EXP50-CPP/DoNotDependOnTheOrderOfScalarObjectEvaluationForSideEffects.ql | Fixes alert message grammar and slightly reformats select. |
| cpp/cert/test/rules/EXP50-CPP/DoNotDependOnTheOrderOfScalarObjectEvaluationForSideEffects.expected | Updates expected results to match the updated alert message (and regenerated output). |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Low
| } | ||
|
|
||
| pragma[noinline, nomagic] | ||
| pragma[inline] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
please enter the description of your change here
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.