fix(core): Capture Anthropic stream stop_reason from message_delta#21907
Open
nicohrubec wants to merge 1 commit into
Open
fix(core): Capture Anthropic stream stop_reason from message_delta#21907nicohrubec wants to merge 1 commit into
nicohrubec wants to merge 1 commit into
Conversation
The Anthropic streaming instrumentation only read `stop_reason` from `event.message.stop_reason`, but a real stream never populates that — `event.message` appears only on `message_start` (where `stop_reason` is `null`), and the final reason arrives on the `message_delta` event as `delta.stop_reason`. So `finish_reasons` was silently dropped for real streams. Reads it from `message_delta.delta` (the dead `message.stop_reason` path is removed) and re-adds the `finish_reasons` assertions to the streaming tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
nicohrubec
requested review from
JPeer264,
andreiborza and
mydea
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #21906.
Small bug that was uncovered by moving the integration test suite to real clients: The stop reason was not being recorded correctly during streaming because it was read from the wrong event.