Skip to content

feat(server-utils): Implement orchestrion-based express integration #21889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mydea wants to merge 7 commits into
base: develop
Choose a base branch
from
+1,002 −287
Draft

feat(server-utils): Implement orchestrion-based express integration #21889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d1b40c
feat(server-utils): Add orchestrion-based express integration
mydea Jul 1, 2026
3e291f8
ref files
mydea Jul 1, 2026
f3df0fa
tests
mydea Jul 1, 2026
4f18e01
test and clarification
mydea Jul 1, 2026
bce81db
add failing test
mydea Jul 1, 2026
9b43cbb
fix nested path handling
mydea Jul 1, 2026
43fd252
small fixes
mydea Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dev-packages/node-integration-tests/suites/express/tracing/instrument-filterStatusCode.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

if (process.env.USE_ORCHESTRION === 'true') {
Sentry.experimentalUseDiagnosticsChannelInjection();
}
Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
Expand Down
3 changes: 3 additions & 0 deletions dev-packages/node-integration-tests/suites/express/tracing/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

if (process.env.USE_ORCHESTRION === 'true') {
Sentry.experimentalUseDiagnosticsChannelInjection();
}
Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
Expand Down
22 changes: 22 additions & 0 deletions dev-packages/node-integration-tests/suites/express/tracing/scenario.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,28 @@ app.post('/test-post-ignore-body', function (req, res) {
res.send({ status: 'ok', body: req.body });
});

// A mounted sub-router, so we get a `router`-type layer wrapping a
// `request_handler` layer — used to assert the router span encloses the route
// handler span it dispatches.
const userRouter = express.Router();
userRouter.get('/:id', (_req, res) => {
// Delay the response so the difference between the two instrumentations'
// router-span durations is unambiguous: the orchestrion router span stays
// open until the response finishes (~this delay), while the OTel one ends
// immediately (~0ms).
setTimeout(() => res.send({ response: 'response user' }), 100);
});
app.use('/test/router/user', userRouter);

// A sub-router mounted under a *parameterized* path. The transaction name /
// `http.route` should keep the parameter (`:version`) rather than the concrete
// value, otherwise route cardinality explodes.
const versionedRouter = express.Router({ mergeParams: true });
versionedRouter.get('/user', (_req, res) => {
res.send({ response: 'response versioned' });
});
app.use('/test/version/:version', versionedRouter);

Sentry.setupExpressErrorHandler(app);

startExpressServerAndSendPortToRunner(app);
Loading
Loading