feat(server-utils): Migrate @opentelemetry/instrumentation-graphql to orchestrion#21885
Draft
chargome wants to merge 3 commits into
Draft
feat(server-utils): Migrate @opentelemetry/instrumentation-graphql to orchestrion#21885chargome wants to merge 3 commits into
@opentelemetry/instrumentation-graphql to orchestrion#21885chargome wants to merge 3 commits into
Conversation
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d573508. Configure here.
| // Important for e.g. @sentry/aws-serverless because this would otherwise overwrite the name again. | ||
| rootSpan.updateName( | ||
| `${spanToJSON(rootSpan).data['original-description']} (${getGraphqlOperationNamesFromAttribute(existingOperations)})`, | ||
| ); |
There was a problem hiding this comment.
Root span name omits operation
Medium Severity
In finalizeExecuteSpan, when sentry.graphql.operation on the root span is already a string, the attribute is updated to an array including the new operation, but rootSpan.updateName still formats the suffix from the old string-only existingOperations, so the renamed root span can omit the current GraphQL operation.
Reviewed by Cursor Bugbot for commit d573508. Configure here.
In finalizeExecuteSpan, when the root span's sentry.graphql.operation attribute was already a string, it was merged into an array for the attribute but the renamed span suffix was still formatted from the stale string-only value — dropping the current operation from the displayed name. Derive both the attribute and the rename suffix from a single merged value so they can no longer diverge. Reachable array-branch behavior is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP