Skip to content

ref(deno): add deno-integration-tests dev-package#21827

Open
isaacs wants to merge 1 commit into
developfrom
isaacs/deno-integration-tests
Open

ref(deno): add deno-integration-tests dev-package#21827
isaacs wants to merge 1 commit into
developfrom
isaacs/deno-integration-tests

Conversation

@isaacs

@isaacs isaacs commented Jun 27, 2026

Copy link
Copy Markdown
Member

Move the 'mysql' devDep out of the deno SDK (since we'll have many more to follow in short order) in favor of a deno-integration-tests package, similar to node-integration-tests and bun-integration-tests.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

Note: conflicts somewhat with #21826, but easy enough to just move the deno-pg test into place, either on that PR or this one, depending on what lands first.

@isaacs isaacs requested a review from a team as a code owner June 27, 2026 04:12
@isaacs isaacs requested review from JPeer264, andreiborza and mydea and removed request for a team June 27, 2026 04:12
Comment thread package.json
Comment thread dev-packages/deno-integration-tests/package.json Outdated
Comment thread dev-packages/deno-integration-tests/package.json Outdated
Comment thread dev-packages/deno-integration-tests/scripts/download-deno-types.mjs Dismissed
@isaacs isaacs force-pushed the isaacs/deno-integration-tests branch from ed4e650 to 54823eb Compare June 27, 2026 04:18
Comment thread dev-packages/deno-integration-tests/tsconfig.json Outdated
@isaacs isaacs force-pushed the isaacs/deno-integration-tests branch from 54823eb to 4589370 Compare June 29, 2026 20:13

@JPeer264 JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm locally. Just added couple of comments

Comment thread dev-packages/deno-integration-tests/scripts/install-deno.mjs
Comment thread dev-packages/deno-integration-tests/package.json Outdated
Comment thread dev-packages/deno-integration-tests/package.json
Comment thread packages/deno/package.json
@isaacs isaacs force-pushed the isaacs/deno-integration-tests branch 2 times, most recently from 5b304fb to 5acf6c2 Compare July 2, 2026 15:13

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5acf6c2. Configure here.

Comment thread dev-packages/deno-integration-tests/scripts/install-deno.mjs
Comment thread dev-packages/deno-integration-tests/scripts/download.mjs Outdated
Move the `mysql` and `pg` devDeps out of the deno SDK (since we'll have
many more to follow in short order) in favor of a deno-integration-tests
package, similar to node-integration-tests and bun-integration-tests.
@isaacs isaacs force-pushed the isaacs/deno-integration-tests branch from 5acf6c2 to 5aa9803 Compare July 2, 2026 15:20
@isaacs isaacs enabled auto-merge (squash) July 2, 2026 15:21
Comment thread dev-packages/deno-integration-tests/scripts/install-deno.mjs Dismissed
Comment thread dev-packages/deno-integration-tests/scripts/download-deno-types.mjs Dismissed
Comment thread dev-packages/deno-integration-tests/scripts/install-deno.mjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants