Skip to content

test: Verify Java 8 API compatibility coverage #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adinauer wants to merge 1 commit into from
Closed

test: Verify Java 8 API compatibility coverage #5747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...p-client-5/src/main/java/io/sentry/transport/apache/ApacheHttpClientTransportFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public ApacheHttpClientTransportFactory() {

public ApacheHttpClientTransportFactory(final @NotNull TimeValue connectionTimeToLive) {
this.connectionTimeToLive =
Objects.requireNonNull(connectionTimeToLive, "connectionTimeToLive is required");
java.util.Objects.requireNonNullElse(connectionTimeToLive, TimeValue.ofMinutes(1));
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion sentry-jul/src/main/java/io/sentry/jul/SentryHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ private void retrieveProperties() {
private @NotNull Breadcrumb createBreadcrumb(final @NotNull LogRecord record) {
final Breadcrumb breadcrumb = new Breadcrumb();
breadcrumb.setLevel(formatLevel(record.getLevel()));
breadcrumb.setCategory(record.getLoggerName());
breadcrumb.setCategory(java.util.Objects.requireNonNullElse(record.getLoggerName(), ""));
if (record.getParameters() != null) {
try {
breadcrumb.setMessage(formatMessage(record.getMessage(), record.getParameters()));
Expand Down
2 changes: 1 addition & 1 deletion sentry-logback/src/main/java/io/sentry/logback/SentryAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ private String formatted(@NotNull ILoggingEvent loggingEvent) {
protected @NotNull Breadcrumb createBreadcrumb(final @NotNull ILoggingEvent loggingEvent) {
final Breadcrumb breadcrumb = new Breadcrumb();
breadcrumb.setLevel(formatLevel(loggingEvent.getLevel()));
breadcrumb.setCategory(loggingEvent.getLoggerName());
breadcrumb.setCategory(Objects.requireNonNullElse(loggingEvent.getLoggerName(), ""));
breadcrumb.setMessage(formatted(loggingEvent));
return breadcrumb;
}
Expand Down
2 changes: 1 addition & 1 deletion sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ internal object SentryOkHttpUtils {
val headers = mutableMapOf<String, String>()

for (i in 0 until requestHeaders.size) {
val name = requestHeaders.name(i)
val name = java.util.Objects.requireNonNullElse(requestHeaders.name(i), "")

// header is only sent if isn't sensitive
if (HttpUtils.containsSensitiveHeader(name)) {
Expand Down
Loading