fix(android): Avoid Math floor APIs#5743
Merged
Merged
Conversation
Replace Math.floorDiv and Math.floorMod in the shared timestamp formatter with local helpers so Android consumers do not call APIs unavailable on older supported Android versions. Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
markushi
approved these changes
Jul 8, 2026
runningcode
approved these changes
Jul 8, 2026
Contributor
|
We should def add a test for this. |
Move the floor division and modulo replacements into a dedicated SentryMath class with Android Open Source Project attribution and third-party notices. Add tests that compare the helper behavior against Java Math for edge cases. Co-Authored-By: Claude <noreply@anthropic.com>
…android-floor-div
Remove the incorrect AOSP attribution for SentryMath. The referenced Android Math source is GPLv2 with the Classpath exception, not Apache 2.0. Implement the helpers directly from quotient and remainder semantics instead. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4c04bb8 | 350.71 ms | 413.63 ms | 62.92 ms |
| bb0ff41 | 315.84 ms | 350.76 ms | 34.92 ms |
| 7c1a728 | 289.46 ms | 368.15 ms | 78.69 ms |
| ff8eea4 | 313.42 ms | 337.08 ms | 23.66 ms |
| bbc35bb | 298.53 ms | 372.17 ms | 73.64 ms |
| 91bb874 | 311.00 ms | 363.47 ms | 52.47 ms |
| abfcc92 | 337.38 ms | 427.39 ms | 90.00 ms |
| ae7fed0 | 293.84 ms | 380.22 ms | 86.38 ms |
| 3998a95 | 415.94 ms | 478.54 ms | 62.60 ms |
| d15471f | 307.28 ms | 381.85 ms | 74.57 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4c04bb8 | 0 B | 0 B | 0 B |
| bb0ff41 | 0 B | 0 B | 0 B |
| 7c1a728 | 0 B | 0 B | 0 B |
| ff8eea4 | 1.58 MiB | 2.28 MiB | 718.64 KiB |
| bbc35bb | 1.58 MiB | 2.12 MiB | 553.01 KiB |
| 91bb874 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| ae7fed0 | 1.58 MiB | 2.12 MiB | 551.77 KiB |
| 3998a95 | 1.58 MiB | 2.10 MiB | 532.96 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
Use Apache-licensed Guava LongMath floor division logic for SentryMath and restore the matching third-party attribution. Keep floorMod implemented through floorDiv so it matches Math.floorMod for negative divisors too. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b5c0278. Configure here.
romtsn
reviewed
Jul 8, 2026
romtsn
approved these changes
Jul 8, 2026
Update the unreleased changelog entry to call out the Android API compatibility failure more directly. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📜 Description
Replace
Math.floorDivandMath.floorModusage inSentryIso8601Utilswith a package-privateSentryMathhelper.💡 Motivation and Context
Fixes #5741
SentryIso8601Utilslives in the sharedsentrymodule and is reachable from Android. Android supports minSdk 21 in this repo, butjava.lang.Math.floorDiv/floorModare only available on newer Android API levels. Calling them from shared code can crash Android apps on supported older devices withNoSuchMethodError.The replacement helper adapts Apache-licensed Guava
LongMathfloor division logic and adds matching attribution inTHIRD_PARTY_NOTICES.md.floorModis implemented throughfloorDivso it matches JavaMath.floorModfor both positive and negative divisors.💚 How did you test it?
./gradlew :sentry:test --tests "io.sentry.vendor.SentryMathTest" --tests "io.sentry.DateUtilsTest"./gradlew :sentry:animalsnifferMain./gradlew spotlessApply apiDumprg -n "\\bMath\\.(floorDiv|floorMod)" sentry/src/main/java sentry-android-core/src/main/java -g '*.java' -g '*.kt'📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.