fix(android): identify and correctly structure Java/Kotlin frames… by supervacuus · Pull Request #5116 · getsentry/sentry-java

supervacuus · 2026-02-25T10:01:03Z

…in mixed Tombstone stack traces.

📜 Description

This PR adds:

identification of platform="java" in mixed platform Tombstone stack frames
restructuring of those platform="java" frames to the expected backend format (using module, function, and platform: "java" instead of package, function, instruction_addr as used for native frames)
a snapshot test against the tombstone that checks the identification of Java frames and in-app doesn't regress

💡 Motivation and Context

This is a planned item of the "wrap-up" UI improvements in https://linear.app/getsentry/project/tombstone-support-android-0024cb6e3ffd/

It covers the SDK part of https://linear.app/getsentry/issue/ANDROID-265/improve-ux-for-mixed-stacktraces (getsentry/sentry#107318).

💚 How did you test it?

📝 Checklist

I added GH Issue ID & Linear ID
I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…mixed Tombstone stack traces

linear · 2026-02-25T10:01:08Z

ANDROID-265 Improve UX for mixed stacktraces

github-actions · 2026-02-25T10:01:27Z

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

Bug Fixes 🐛

(android) Identify and correctly structure Java/Kotlin frames… by supervacuus in #5116

_{🤖 This preview updates automatically when you update the PR.}

supervacuus · 2026-02-25T10:15:28Z

While testing this manually, it became apparent that the SDK-level inApp detection and the one on the server disagree. See here: https://sentry-sdks.sentry.io/issues/7288803722/events/af5e7573571f4cd98616f947e081ad09/

In the event, only the JNI frame is kept as inApp because it is a native frame. The Java frames from the package are marked as "framework" -> "system (see the data property for evidence of an overwrite):

Not sure if this is really a problem, but it certainly was unexpected.

Please also keep in mind that this PR should be blocked for merging/releasing until UI issues are fixed here: getsentry/sentry#107318. For instance, currently, there is no stable rendering between native and Java frames.

github-actions · 2026-02-25T10:25:30Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	369.93 ms	463.70 ms	93.77 ms
Size	0 B	0 B	0 B

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`abfcc92`	309.54 ms	380.32 ms	70.78 ms
`4e3e79d`	328.10 ms	395.64 ms	67.54 ms
`8c1fb22`	316.62 ms	352.78 ms	36.16 ms
`b67bb28`	307.59 ms	341.24 ms	33.65 ms
`d15471f`	361.89 ms	378.07 ms	16.18 ms
`22f4345`	313.52 ms	364.96 ms	51.44 ms
`6727e14`	337.22 ms	373.94 ms	36.71 ms
`fc5ccaf`	322.49 ms	405.25 ms	82.76 ms
`22f4345`	314.79 ms	375.02 ms	60.23 ms
`2195398`	319.02 ms	342.38 ms	23.36 ms

App size

Revision	Plain	With Sentry	Diff
`abfcc92`	1.58 MiB	2.13 MiB	557.31 KiB
`4e3e79d`	0 B	0 B	0 B
`8c1fb22`	0 B	0 B	0 B
`b67bb28`	0 B	0 B	0 B
`d15471f`	1.58 MiB	2.13 MiB	559.54 KiB
`22f4345`	1.58 MiB	2.29 MiB	719.83 KiB
`6727e14`	1.58 MiB	2.28 MiB	718.64 KiB
`fc5ccaf`	1.58 MiB	2.13 MiB	557.54 KiB
`22f4345`	1.58 MiB	2.29 MiB	719.83 KiB
`2195398`	0 B	0 B	0 B

sentry · 2026-03-13T10:18:42Z

📲 Install Builds

Android

🔗 App Name	App ID	Version	Configuration
SDK Size	io.sentry.tests.size	8.47.0 (1)	release

⚙️ sentry-android Build Distribution Settings

markushi

LGTM, nice!, I'll not marked it as approved, as we should get the frontend changes in first.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Tests expect empty string but production code returns null
- Updated both bare-function Tombstone parser tests to assert null module values, matching production behavior when no module can be extracted.

Or push these changes by commenting:

@cursor push 59609e9828

Preview (59609e9828)

diff --git a/sentry-android-core/src/test/java/io/sentry/android/core/internal/tombstone/TombstoneParserTest.kt b/sentry-android-core/src/test/java/io/sentry/android/core/internal/tombstone/TombstoneParserTest.kt
--- a/sentry-android-core/src/test/java/io/sentry/android/core/internal/tombstone/TombstoneParserTest.kt
+++ b/sentry-android-core/src/test/java/io/sentry/android/core/internal/tombstone/TombstoneParserTest.kt
@@ -13,6 +13,7 @@
 import kotlin.test.Test
 import kotlin.test.assertEquals
 import kotlin.test.assertNotNull
+import kotlin.test.assertNull
 import org.mockito.kotlin.mock
 
 class TombstoneParserTest {
@@ -496,7 +497,7 @@
     val frame = event.threads!![0].stacktrace!!.frames!![0]
     assertEquals("java", frame.platform)
     assertEquals("myMethod", frame.function)
-    assertEquals("", frame.module)
+    assertNull(frame.module)
   }
 
   @Test
@@ -505,7 +506,7 @@
     val frame = event.threads!![0].stacktrace!!.frames!![0]
     assertEquals("java", frame.platform)
     assertEquals("myMethod", frame.function)
-    assertEquals("", frame.module)
+    assertNull(frame.module)
   }
 
   @Test

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

Applied via @cursor push command

* test(android): add proguard tombstone test cases * remove esr from the expected register set (used only for hard-faults) * Format code * re-enable sentryCompose and disable auto-installation in the gradle plugin * adapt parseTombstoneWithJavaFunctionName in TombstoneParserTest to epitaph and make the snapshot test independent of order. --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Double normalizeFunctionName call for same input
- The Java frame path now normalizes frame.functionName once and reuses that normalized value for both module and function extraction.

Or push these changes by commenting:

@cursor push 44ba30fd16

Preview (44ba30fd16)

diff --git a/sentry-android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java b/sentry-android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java
--- a/sentry-android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java
+++ b/sentry-android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java
@@ -152,8 +152,9 @@
       final SentryStackFrame stackFrame = new SentryStackFrame();
       if (isJavaFrame(frame)) {
         stackFrame.setPlatform("java");
-        final String module = extractJavaModuleName(frame.functionName);
-        stackFrame.setFunction(extractJavaFunctionName(frame.functionName));
+        final String normalizedFunctionName = normalizeFunctionName(frame.functionName);
+        final String module = extractJavaModuleName(normalizedFunctionName);
+        stackFrame.setFunction(extractJavaFunctionName(normalizedFunctionName));
         stackFrame.setModule(module);
 
         // For Java frames, check in-app against the module (package name), which is what
@@ -217,21 +218,19 @@
     return normalized;
   }
 
-  private static @Nullable String extractJavaModuleName(String fqFunctionName) {
-    final String normalized = normalizeFunctionName(fqFunctionName);
-    if (normalized.contains(".")) {
-      return normalized.substring(0, normalized.lastIndexOf("."));
+  private static @Nullable String extractJavaModuleName(String normalizedFunctionName) {
+    if (normalizedFunctionName.contains(".")) {
+      return normalizedFunctionName.substring(0, normalizedFunctionName.lastIndexOf("."));
     } else {
       return null;
     }
   }
 
-  private static @Nullable String extractJavaFunctionName(String fqFunctionName) {
-    final String normalized = normalizeFunctionName(fqFunctionName);
-    if (normalized.contains(".")) {
-      return normalized.substring(normalized.lastIndexOf(".") + 1);
+  private static @Nullable String extractJavaFunctionName(String normalizedFunctionName) {
+    if (normalizedFunctionName.contains(".")) {
+      return normalizedFunctionName.substring(normalizedFunctionName.lastIndexOf(".") + 1);
     } else {
-      return normalized;
+      return normalizedFunctionName;
     }
   }

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

Applied via @cursor push command

supervacuus · 2026-07-03T14:48:09Z

@0xadam-brown and @runningcode, you were added as reviewers only because it was merged from main to check whether the branch had diverged too far. This is currently blocked by decisions outside this PR, primarily related to https://linear.app/getsentry/team/JAVA/projects/view/roadmap-f1c601612fba.

Long story short: no need to review beyond any individual interests (and also no approval, please; if this PR is a problem, let's just close it for now).

supervacuus · 2026-07-03T15:04:59Z

if this PR is a problem, let's just close it for now

Maybe that is the solution to begin with. The corresponding UI PR was also closed (getsentry/sentry#107318).

fix(android): identify and correctly structure Java/Kotlin frames in …

6930694

…mixed Tombstone stack traces

supervacuus requested review from adinauer, lcian, markushi and romtsn as code owners February 25, 2026 10:01

supervacuus added 2 commits February 25, 2026 11:05

update changelog

4d4b081

Merge branch 'main' into fix/android/id_java_kotlin_frames_tombstone

1ee2738

cursor Bot reviewed Feb 25, 2026

View reviewed changes

Comment thread ...ry-android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java

Comment thread ...ry-android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java

support PrettyMethod with_signature formatted java frames

35e1010

supervacuus mentioned this pull request Feb 25, 2026

test(android): add proguard tombstone test cases #5117

Merged

8 tasks

Merge branch 'main' into fix/android/id_java_kotlin_frames_tombstone

2af3888

If there is no module name, module should be null

0635d8a

markushi reviewed Mar 13, 2026

View reviewed changes

Comment thread ...ry-android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java Outdated

cursor Bot reviewed Mar 13, 2026

View reviewed changes

Comment thread ...-android-core/src/test/java/io/sentry/android/core/internal/tombstone/TombstoneParserTest.kt Outdated

cursoragent and others added 3 commits March 13, 2026 10:39

test: assert null java module for bare tombstone methods

10dd21c

Applied via @cursor push command

clean up TombstoneParser.normalizeFunctionName()

f7473a5

supervacuus force-pushed the fix/android/id_java_kotlin_frames_tombstone branch from 4324585 to f7473a5 Compare March 13, 2026 12:11

Merge branch 'main' into fix/android/id_java_kotlin_frames_tombstone

1fdf9f5

sentry Bot reviewed Mar 26, 2026

View reviewed changes

Comment thread ...ry-android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java

cursor Bot reviewed Mar 26, 2026

View reviewed changes

Comment thread ...ry-android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java Outdated

cursoragent and others added 2 commits March 26, 2026 14:35

refactor tombstone java frame name normalization

dee5f92

Applied via @cursor push command

Merge branch 'main' into fix/android/id_java_kotlin_frames_tombstone

b718e01

supervacuus requested review from 0xadam-brown and runningcode as code owners July 3, 2026 14:44

sentry Bot reviewed Jul 3, 2026

View reviewed changes

Comment thread ...-android-core/src/test/java/io/sentry/android/core/internal/tombstone/TombstoneParserTest.kt

update CHANGELOG.md

4f2e6f7

supervacuus closed this Jul 3, 2026

Uh oh!

Uh oh!

Conversation

supervacuus commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

linear Bot commented Feb 25, 2026

Uh oh!

github-actions Bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Bug Fixes 🐛

Uh oh!

supervacuus commented Feb 25, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

sentry Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📲 Install Builds

Android

Uh oh!

markushi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

supervacuus commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supervacuus commented Jul 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

supervacuus commented Feb 25, 2026 •

edited

Loading

github-actions Bot commented Feb 25, 2026 •

edited

Loading

github-actions Bot commented Feb 25, 2026 •

edited

Loading

sentry Bot commented Mar 13, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

supervacuus commented Jul 3, 2026 •

edited

Loading