ref(logging): Decouple async log context#970
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
marked this pull request as ready for review
July 21, 2026 05:23
Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
Drop the removed resume correlation field and cover scoped updates, sanitization, and startup-failure correlation after rebasing.
dcramer
force-pushed
the
refactor/async-log-context
branch
from
July 23, 2026 00:47
949badf to
a754e43
Compare
Build the provider-neutral run context once for async binding and Sentry publication, and narrow its typed projection to optional strings.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cd752ef. Configure here.
Co-Authored-By: David Cramer <david@sentry.io>
Ignore undefined typed context deltas so nested scopes retain parent values just like the emitted attribute store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bind provider-neutral correlation data to a typed async context domain so nested logs and spans inherit it without Slack-shaped logging contracts.
What changed
log-context.tsnow owns the typedLogContext, its telemetry projection, and a strictly scopedrunWithLogContext()API.enterWith()mutation path.AsyncLocalStorage.Checks
pnpm --filter @sentry/junior typecheckpnpm lint127.0.0.1:54322; CI exercises the suite.Requested by David Cramer via Junior.
--
View Junior Session