docs(site): use brand fonts (Dammit Sans headings, Rubik body)#1183
Merged
Conversation
Per design (Steven Lewis): headings use the custom 'Dammit Sans' display font (self-hosted @font-face), body switches from Inter to Rubik. Code stays JetBrains Mono. - docs/public/fonts/dammit-sans-v0.3-bold.otf: self-hosted display face - cli.css: @font-face, --sl-font -> Rubik, --sl-font-headings -> Dammit Sans; apply headings font to .sl-markdown-content h1-h6, .page-title-wrapper h1, .hero h1 - astro.config.mjs: Google Fonts link Inter -> Rubik (JetBrains Mono kept) Dammit Sans is a display face with a limited glyph set, so headings fall back to Rubik for any missing glyphs (/ * \ | ^ _ `). Verified via astro build (39 pages): font ships to /fonts/, @font-face + heading var in built CSS, Rubik in the Google Fonts link.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c105cb0. Configure here.
Contributor
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 5199 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.65% 81.65% —%
==========================================
Files 410 410 —
Lines 28334 28334 —
Branches 18437 18437 —
==========================================
+ Hits 23136 23135 -1
- Misses 5198 5199 +1
- Partials 1893 1892 -1Generated by Codecov Action |
The @font-face used a root-absolute /fonts/... URL, which 404s on PR previews that serve under a base path (DOCS_BASE_PATH, e.g. /_preview/pr-N) — headings would fall back to Rubik there. Move the font into src/ and reference it with a relative URL so Vite bundles + hashes it and rewrites the URL respecting base. Verified: prod build -> /_astro/dammit-sans-*.otf; DOCS_BASE_PATH=/_preview/pr-1183 build -> /_preview/pr-1183/_astro/dammit-sans-*.otf. Addresses Cursor Bugbot.
@sentry/starlight-theme already self-hosts Rubik (as 'Rubik Variable') and sets it as the default --sl-font. Point --sl-font (and the headings fallback) at 'Rubik Variable' and drop Rubik from the Google Fonts link — body now uses the theme's self-hosted face with no redundant CDN dependency. JetBrains Mono (which the theme does not ship — it uses IBM Plex Mono) stays on Google Fonts. Also complete the missing-glyph note (# and ~) in the cli.css comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the brand typography from design (Steven Lewis): Dammit Sans for headings, Rubik for body. Code stays JetBrains Mono. Follow-up to the site brand assets (#1181).
Changes
@font-facewith a relativeurl("../fonts/…")so Vite bundles + hashes it and respects the sitebase(font ships to/_astro/dammit-sans-*.<hash>.otf, base-aware for PR previews). Applied to.sl-markdown-contenth1–h6, the page-title h1, and the hero h1 via--sl-font-headings.@sentry/starlight-themealready ships it). Removed the previousInteroverride and dropped Rubik from the Google Fonts link — no redundant CDN dependency.docs/src/fonts/dammit-sans-v0.3-bold.otf(the custom v0.3 build).Notes
# / * \ | ^ _ \~), so headings fall back to **Rubik** per-character for any missing glyph. Across all docs the only plain-text heading affected is "TLS / Corporate Proxies" (the/falls back to Rubik); command headings are backtick` (JetBrains Mono), unaffected.--sl-font-headings.Verification
astro buildOK (39 pages). Prod build →url(/_astro/dammit-sans-*.otf);DOCS_BASE_PATH=/_preview/pr-1183build →url(/_preview/pr-1183/_astro/dammit-sans-*.otf). Google Fonts link loads JetBrains Mono only; body resolves to the theme's self-hosted Rubik Variable; headings resolve to Dammit Sans.28048bc0d.