test_benchmark.py: Replace DEFAULT_ARG with BENCHMARK_MODE#27294
Open
sbc100 wants to merge 1 commit into
Open
Conversation
This was already acting like a global mode for the benchmark runner, it wasn't really something that an individual test could ever override.
sbc100
commented
Jul 9, 2026
| if expected_output is not None and expected_output not in output: | ||
| raise ValueError('Incorrect benchmark output:\n' + output) | ||
|
|
||
| if not output_parser or args == ['0']: # if arg is 0, we are not running code, and have no output to parse |
Collaborator
Author
There was a problem hiding this comment.
Note that checking for args == ['0'] wasn't as precise here since benchmarks like lua were passing their own args, which meant the mode was sometimes passed as the second argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was already acting like a global mode for the benchmark runner, it wasn't really something that an individual test could ever override.