[test] Eliminate duplicate HTML shells in browser tests#27282
Open
sbc100 wants to merge 1 commit into
Open
Conversation
sbc100
force-pushed
the
clean-up-duplicate-test-shells
branch
2 times, most recently
from
61dc63a to
eeb6aef
Compare
Remove 10 duplicate HTML shell files from the test suite and replace them with programmatic solutions. - Use --pre-js to dynamically configure canvas size, pre-initialize WebGL contexts, and pre-allocate heap on standard templates. - Monkey-patch Module.print/printErr in --pre-js to verify output without custom shells. - Dynamically inject interactive UI buttons in --pre-js. - Clone the canvas in --pre-js to strip default event listeners. - Dynamically generate static HTML assets in Python tests by modifying shell_minimal.html. - Update embind benchmark to use default HTML shell. This significantly reduces code duplication and ensures test shells don't drift from the main templates.
sbc100
force-pushed
the
clean-up-duplicate-test-shells
branch
from
eeb6aef to
b096838
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 10 duplicate HTML shell files from the test suite and replace them with programmatic solutions.
This significantly reduces code duplication and ensures test shells don't drift from the main templates.