Gtk4Prep: Sidebar stack - do not use deprecated signal#1755
Merged
Conversation
danirabbit
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack.remove signal does not exist in Gtk4 and we can execute the handler commands in the
remove_tabfunction of Sidebar anyway.At the moment we only use one sidebar tab and there are no no immediate plans to add anymore (The extra tab used to be used for the symbol pane) so we could remove the stack and switcher altogether. However, the functionality could be useful in future for some git related or other functions which do not need to be continually shown so leaving in place for now.