Gtk4Prep: Replace dialog.run () and filechooser.run ()#1739
Draft
jeremypw wants to merge 23 commits into
Draft
Conversation
Member
|
Any reason you're using |
Collaborator
Author
|
Valadoc says Using show () does mean |
danirabbit
requested changes
Jun 24, 2026
danirabbit
left a comment
Member
There was a problem hiding this comment.
Don't forget to update POTFILES since you removed a file
# Conflicts: # src/MainWindow.vala
Member
|
Since this is a pretty large branch now, can you break out the async function changes into a separate branch? It'd be nice to have its own commit in git history. If it's too much of a pain, don't worry about it :) |
Collaborator
Author
|
No problem, it has expanded somewhat ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The run () functions is replaced with show () together with a handler for the "response" signal as will be needed in Gtk4. The dialogs are explicitly created modal. In some cases where there is code that must wait for the response, it is necessary to use async functionality and
yieldas dialog.show () is not blocking.In passing
An unused dialog is removed
show_all ()is moved into the Preferences dialog class where it would normally be.