Disable AddCommitsToPR on VS insertion to avoid spurious build failures#857
Open
marcpopMSFT wants to merge 1 commit into
Open
Disable AddCommitsToPR on VS insertion to avoid spurious build failures#857marcpopMSFT wants to merge 1 commit into
marcpopMSFT wants to merge 1 commit into
Conversation
The MicroBuild Insert VS Payload task's 'Copy Commit Details to PR' feature (AddCommitsToPR) fatally fails the task *after* the insertion PR has already been created when it cannot compute a commit diff. This happened in build 3009141: the PR (DevDiv #753336) was created successfully, then the task errored with 'No changes found between 20260626.3 and 20260626.2' and exited 1. Triggers: the metadata service had no ADO bearer token, so it fell back to legacy logic and selected a canceled same-commit sibling build (20260626.3) as the diff baseline, yielding an empty diff that the plugin treats as fatal. The commits rolled into these insertions are version-number updates rather than real code changes, so the auto-generated commit list provides little value and isn't worth failing the build over. The insertion PR, reviewers, build policies and auto-complete are unaffected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Disables MicroBuild’s AddCommitsToPR behavior for the “Insert VS Payload” step to prevent otherwise-successful insertion runs from failing due to a non-essential post-PR “Copy Commit Details to PR” step.
Changes:
- Set
AddCommitsToPR: falsefor the VS insertion task. - Added in-file rationale documenting the known failure mode and why the feature is not worth failing the build over for workload-version insertions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set
AddCommitsToPR: falsefor the MicroBuild Insert VS Payload task ineng/pipelines/templates/steps/workload-insertion-steps.yml.Why
In build 3009141 the VS insertion succeeded — the PR (DevDiv #753336) was created — but the task then failed with exit code 1 on the post-PR "Copy Commit Details to PR" step:
Root cause
The
AddCommitsToPRfeature tries to compute the list of commits to paste into the PR description after the PR already exists, and treats failure as fatal. Two environmental factors triggered it:No ADO bearer token is available to call the metadata service— so it fell back to legacy "previous build" logic.20260626.3, build 3009185, same source commit7ed63c0f) as the diff baseline → empty diff → fatalNo changes found.So a cosmetic, post-PR description step is failing builds even though the insertion itself worked.
Why disabling is acceptable
The commits rolled into these insertions are version-number updates, not meaningful code changes, so the auto-generated commit list adds little value and isn't worth failing the build over. The information is still discoverable from the component-version diff and this repo's history.
Impact
Follow-ups (not in this PR)