Skip to content

BUG: do not change the dtype in asarray(array_from_another_library) #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ev-br wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −2
Open

BUG: do not change the dtype in asarray(array_from_another_library) #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions array_api_strict/_creation_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,12 @@ def asarray(

res = np.array(obj, dtype=_np_dtype, copy=copy)

# numpy default dtype may differ; if so, adjust the dtype
if dtype is None and device is not None:
# numpy default dtype may differ; if so, adjust the dtype---
# unless `obj` is already an array, potentially from some other library.
# In the latter case, `obj.dtype` is a thing, numpy has already done the
# conversion and `res.dtype` is the numpy analog of `obj.dtype`
# (if numpy failed to convert `obj`, it has already raised an exception).
if dtype is None and device is not None and not hasattr(obj, "dtype"):
res_dtype = DType(res.dtype)
# The dtype selected by Numpy might not be the default dtype
# on this device. We thus find the default dtype for the dtype "kind", and
Expand Down
7 changes: 7 additions & 0 deletions array_api_strict/tests/test_creation_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,13 @@ def test_asarray_device_2():
assert y.dtype == float64


def test_asarray_device_1():
# regression test for https://github.com/data-apis/array-api-strict/issues/222
x = np.ones(3, dtype=np.float32)
y = asarray(x, device=Device('device1'))
assert y.dtype == float32


@pytest.mark.parametrize("api_version", ['2021.12', '2022.12', '2023.12'])
def from_dlpack_2023_12(api_version):
if api_version != '2022.12':
Expand Down
Loading