Skip to content

TST: Added test to check if _funcs.__all__ is in sync#828

Merged
lucascolley merged 6 commits into
data-apis:mainfrom
prady0t:update_funcs.all
Jul 7, 2026
Merged

TST: Added test to check if _funcs.__all__ is in sync#828
lucascolley merged 6 commits into
data-apis:mainfrom
prady0t:update_funcs.all

Conversation

@prady0t

@prady0t prady0t commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Closes: #821

@prady0t
added test to check if __all__ is in sync
c7e5f0c 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t

prady0t commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

The failing test is already a great demonstration lol. @lucascolley have a look before I merge main.

@lucascolley

lucascolley commented Jul 2, 2026

Copy link
Copy Markdown
Member

nice 👍 I wonder whether there is a way to get ruff to enforce this, though?

@prady0t

prady0t commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Ruff has checks for invalid entry in __all__, like :https://docs.astral.sh/ruff/rules/invalid-all-object/#why-is-this-bad
Or maybe checks for alphabetical order, duplicate entry, etc. Nothing that solves exactly this problem.

prady0t added 2 commits July 4, 2026 16:22
@prady0t
Merge branch 'main' of https://github.com/prady0t/array-api-extra int…
d991d3c 
…o update_funcs.all
@prady0t
add unravel_index
f6275fe 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@lucascolley lucascolley added this to the 0.11.1 milestone Jul 4, 2026
@lucascolley lucascolley added maintenance general maintenance testing labels Jul 4, 2026
@lucascolley lucascolley self-requested a review July 7, 2026 12:16
lucascolley
lucascolley reviewed Jul 7, 2026
View reviewed changes

@lucascolley lucascolley left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks Pradyot! Could we add a similar test for _delegation?

prady0t and others added 3 commits July 8, 2026 01:31
@prady0t
Merge branch 'main' into update_funcs.all
199d87b
@prady0t
add test for _delegation
a9df7a3 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t
merge
2facc45 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t

prady0t commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Could we add a similar test for _delegation?

Done!

@lucascolley lucascolley merged commit aa3b9c6 into data-apis:main Jul 7, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucascolley lucascolley lucascolley approved these changes

Assignees

No one assigned

Labels

maintenance general maintenance testing

Projects

None yet

Milestone

0.11.1

Development

Successfully merging this pull request may close these issues.

MAINT: update _funcs.__all__

2 participants

@prady0t @lucascolley