Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI test version is being updated to 2025.12, but the actual implementation still declares support for 2024.12 in multiple places. There is a discrepancy between what's being tested and what the code declares it supports. The following files should be reviewed and potentially updated to maintain consistency:
array_api_compat/common/_helpers.py(line 59) -_API_VERSIONSstill only includes "2024.12"array_api_compat/numpy/__init__.py(line 29) -__array_api_version__is "2024.12"array_api_compat/cupy/__init__.py(line 15) -__array_api_version__is "2024.12"array_api_compat/dask/array/__init__.py(line 12) -__array_api_version__is "2024.12"array_api_compat/torch/__init__.py(line 16) -__array_api_version__is "2024.12"docs/index.md(lines 15-16) - Documentation still references 2024.12If the intent is to test against 2025.12 while still implementing 2024.12, this should be documented. Otherwise, these files should be updated together to ensure the library declares support for the version it's being tested against.