-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Expand template argument type deduction #8688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pfultz2
wants to merge
17
commits into
cppcheck-opensource:main
Choose a base branch
from
pfultz2:template-type-deduction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,097
−137
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2c68b09
Add template type deduction
eecd903
Simplify
a43039a
Use a forward walk
695de6e
Handle global function template called from a class scope
b60e55e
Improve member functions
de77bc6
Handle late class members
90c62dc
Handle overloading better
5ad01ad
Simplify and add unit tests
965281d
Improve comments
d966681
Avoid output params
f64190d
Format
81da87b
Use stl algorithm
9b554ac
Format
35e830a
Fix selfcheck
770eeb9
Remvoe unnecessary move
0e81fca
Add test for 13630
e87f8d7
Format
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to have an entry for each file it occurs in so we would at least partially detect future regressions. Heck, we should probably move this to the source instead so we have actual individual suppressions.
Since the scope has widened additional tickets probably need to be filed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well we need to suppress it everytime we use functions like
containsorcalculate, and we are a long ways from being able to instantiate those functions. This isnt catching any errors and just adding burden. I think it would be better as a seperate report like daca.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. It is just a debug warning (those are tracked in daca). Still a new ticket for one of the additional cases would be good for tracking.