Skip to content

fix: updates for latest static binaries#398

Merged
2bndy5 merged 4 commits into
mainfrom
update-static-bin-support
Jul 10, 2026
Merged

fix: updates for latest static binaries#398
2bndy5 merged 4 commits into
mainfrom
update-static-bin-support

Conversation

@2bndy5

@2bndy5 2bndy5 commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator
  • use unified SHA512 checksums file
  • download binaries for windows arm64

also includes some changes that satisify new clippy lints (per Rust v1.97.0).

Summary by CodeRabbit

  • New Features

    • Expanded static binary downloads to support both x86_64 and aarch64 on Windows, Linux, and macOS.
  • Bug Fixes

    • Improved static distribution verification by matching downloads against a shared SHA512SUMS entry.
    • Updated SHA-512 support selection for the relevant platform/architecture targets.
  • Documentation / Improvements

    • Refined clang-tidy output formatting for generated suggestions and line filtering.
    • Adjusted CLI subcommand help text generation to avoid minor formatting inconsistencies.

- use unified SHA512 checksums file
- download binaries for windows arm64

also includes some changes that satisify new clippy lints (per Rust
v1.97.0).
@2bndy5 2bndy5 added the bug Something isn't working label Jul 9, 2026
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.39%. Comparing base (a6cbd53) to head (77bed4b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   92.38%   92.39%           
=======================================
  Files          23       23           
  Lines        3795     3798    +3     
=======================================
+ Hits         3506     3509    +3     
  Misses        289      289           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@2bndy5 2bndy5 marked this pull request as ready for review July 9, 2026 23:07
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8d0cf83d-97a3-44bf-9f11-dbd0ed7fa3db

📥 Commits

Reviewing files that changed from the base of the PR and between 454bb23 and 77bed4b.

📒 Files selected for processing (1)
  • clang-tools-manager/src/downloader/static_dist.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • clang-tools-manager/src/downloader/static_dist.rs

📝 Walkthrough

Walkthrough

Platform gating and static binary checksum handling are updated for additional architectures and shared SHA512SUMS manifests. Clang-tidy formatting and CLI documentation help lookup also receive small ownership-related cleanup changes.

Changes

Downloader platform and checksum handling

Layer / File(s) Summary
Unified platform gating
clang-tools-manager/src/downloader/hashing.rs, clang-tools-manager/src/downloader/static_dist.rs
SHA-512 support and static distribution modules use unified Windows/Linux/macOS and x86_64/aarch64 target conditions.
SHA512SUMS download and verification
clang-tools-manager/src/downloader/static_dist.rs
Binary URLs and checksum caching now use a shared SHA512SUMS manifest and match entries by tool path.

Clang-tidy formatting cleanup

Layer / File(s) Summary
Direct formatting arguments
cpp-linter/src/clang_tools/clang_tidy.rs, cpp-linter/src/common_fs.rs
Clang-tidy output formatting removes unnecessary borrowed arguments while preserving generated content.

CLI documentation help lookup

Layer / File(s) Summary
Subcommand help retrieval
docs/src/lib.rs
Subcommand help generation retrieves get_about() directly before missing-value error handling.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: support for updated static binaries and related downloader updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as low quality.

Comment thread clang-tools-manager/src/downloader/static_dist.rs Outdated
2bndy5 added 2 commits July 9, 2026 16:41
The file can be very large, and we only need part of 1 line from it.
@2bndy5 2bndy5 merged commit d3922e7 into main Jul 10, 2026
85 checks passed
@2bndy5 2bndy5 deleted the update-static-bin-support branch July 10, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant