CI: build and test hstore_plphp alongside the other transforms#35
Merged
Conversation
hstore_plphp shipped in 2.5.0 but was never wired into CI: only jsonb_plphp (and now bytea_plphp) were built and installchecked. Add hstore_plphp to both the PG 11-18 matrix job and the ASAN job, mirroring the jsonb_plphp/bytea_plphp steps. The hstore contrib extension it depends on ships in the postgresql-N package CI already installs, so no extra apt dependency is needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Wiring hstore_plphp into CI surfaced that its test passed only on PG 18: PG 11-17 failed on the final DROP EXTENSION ... CASCADE, whose NOTICE lists cascaded objects in a version-dependent way (PostgreSQL records TRANSFORM dependencies differently across releases, so the count and ordering differ). Every other line of the test was already identical across versions. Silence the cascade NOTICE with client_min_messages = warning around the teardown and regenerate the expected output. This matches how the jsonb_plphp test avoids the issue (it drops its functions explicitly rather than via CASCADE). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hstore_plphpshipped in 2.5.0 but was never actually wired into CI: theworkflow only built and installchecked
jsonb_plphp(and nowbytea_plphp).So the "hstore green across the matrix" claim was really only ever verified
locally.
This adds
hstore_plphpto both the PG 11-18 matrix job and the ASAN job,mirroring the existing
jsonb_plphp/bytea_plphpsteps (build + install +installcheck + failure diffs). The
hstorecontrib extension it depends onships in the
postgresql-Npackage CI already installs (verified per version:hstore.controlis provided bypostgresql-{11,15,18}), so no extra aptdependency is required.
Now all three transform companions are exercised across the full matrix.
🤖 Generated with Claude Code