Skip to content

fix: skip unreadable .env in Boot::loadDotEnv for separate-process tests #10417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gr8man wants to merge 3 commits into
base: develop
Choose a base branch
from
+7 −2
Open

fix: skip unreadable .env in Boot::loadDotEnv for separate-process tests #10417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c62951
fix: silently skip unreadable .env file in loadDotEnv()
gr8man Jul 19, 2026
92eac67
fix: use controlled envDirectory in test bootstrap instead of silenci…
gr8man Jul 20, 2026
a8727ee
ci: trigger rebuild
gr8man Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions system/Boot.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,9 @@ public static function preload(Paths $paths): void
protected static function loadDotEnv(Paths $paths): void
{
require_once $paths->systemDirectory . '/Config/DotEnv.php';
$envDirectory = $paths->envDirectory ?? $paths->appDirectory . '/../'; // @phpstan-ignore nullCoalesce.property
(new DotEnv($envDirectory))->load();

$envDir = $paths->envDirectory ?? dirname($paths->appDirectory); // @phpstan-ignore nullCoalesce.property
(new DotEnv($envDir))->load();
Comment on lines -208 to +210

@michalsn michalsn Jul 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unrelated change. If you want, you can send a separate PR with the refactor.

}

protected static function defineEnvironment(): void
Expand Down
4 changes: 4 additions & 0 deletions system/Test/bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@
require CONFIGPATH . 'Paths.php';
$paths = new Paths();

// Use a controlled environment directory for tests so that
// separate-process tests don't fail on an unreadable .env file.
$paths->envDirectory = $paths->testsDirectory;

@michalsn michalsn Jul 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes behavior for every application test suite. Again, not acceptable.

// Define necessary framework path constants
defined('APPPATH') || define('APPPATH', realpath(rtrim($paths->appDirectory, '\\/ ')) . DIRECTORY_SEPARATOR);
defined('ROOTPATH') || define('ROOTPATH', realpath(APPPATH . '../') . DIRECTORY_SEPARATOR);
Expand Down
Loading