Skip to content

Restore Key one-pagers heading and bold the locale note. #3644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernardhanna merged 1 commit into from
Jul 24, 2026
Merged

Restore Key one-pagers heading and bold the locale note. #3644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions app/TrainingResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,15 @@ public function renderedPdfLinksSectionForLocale(?string $locale = null): string
return '';
}

$noteHtml = '<span class="block mb-4">'.e(__('training.discover_digital_key_one_pagers_note')).'</span>';
$noteHtml = '<span class="block mb-4 font-semibold"><strong>'.e(__('training.discover_digital_key_one_pagers_note')).'</strong></span>';

if (str_contains($section, '[[key_one_pagers_locale_note]]')) {
return str_replace('[[key_one_pagers_locale_note]]', $noteHtml, $section);
$section = str_replace('[[key_one_pagers_locale_note]]', $noteHtml, $section);
if ($this->slug === 'discover-digital-programme' && ! $this->hasKeyOnePagersHeading($section)) {
$section = '<h2 id="key-one-pagers">Key one-pagers</h2>'.$section;
}

return $section;
}

// Discover Digital: inject the note even when locale overrides omit the placeholder.
Expand All @@ -299,10 +304,15 @@ public function renderedPdfLinksSectionForLocale(?string $locale = null): string
}
}

if (! str_contains(mb_strtolower($section), 'key one-pagers')) {
return '<h2 id="key-one-pagers">Key one-pagers</h2>'.$noteHtml.$section;
}
// Always restore the heading when missing. Do not use a plain-text search for
// "key one-pagers" — the supporting-detail paragraph also mentions that phrase.
return '<h2 id="key-one-pagers">Key one-pagers</h2>'.$noteHtml.$section;
}

return $noteHtml.$section;
protected function hasKeyOnePagersHeading(string $html): bool
{
return preg_match('/<h2[^>]*\bid=(["\'])key-one-pagers\1[^>]*>/is', $html) === 1
|| preg_match('/<h2[^>]*>\s*Key one-pagers\s*<\/h2>/is', $html) === 1
|| preg_match('/(?:<div[^>]*>\s*)?<strong>\s*Key one-pagers\s*<\/strong>/is', $html) === 1;
}
}
Loading