Skip to content

Use Trix for translated training PDF link fields in Nova. #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernardhanna merged 1 commit into from
Jul 24, 2026
Merged

Use Trix for translated training PDF link fields in Nova. #3640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions app/Nova/TrainingResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,13 @@ public function fields(Request $request): array
continue;
}

$pdfTranslationFields[] = Textarea::make(
$pdfTranslationFields[] = Trix::make(
'PDF links ('.strtoupper($locale).')',
'locale_'.$locale.'_pdf_links_section'
)
->nullable()
->rows(10)
->hideFromIndex()
->help('Leave empty to keep the default English PDF links for this language. Paste the full HTML (same structure as PDF links section) with translated file URLs after uploading to S3.')
->help('Leave empty to keep the default English PDF links. Use the toolbar to add links (select text → link), lists, and headings. Include [[key_one_pagers_locale_note]] if you want the translated intro sentence.')
->resolveUsing(function () use ($locale) {
$overrides = $this->resource->locale_overrides ?? [];

Expand All @@ -84,7 +83,7 @@ public function fields(Request $request): array
}

$value = $request->get($requestAttribute);
if ($value === null || trim((string) $value) === '') {
if ($value === null || trim(strip_tags((string) $value)) === '') {
unset($overrides[$locale]['pdf_links_section']);
} else {
$overrides[$locale]['pdf_links_section'] = $value;
Expand Down
Loading