chore(tests): add regression tests for UiController#5481
Merged
SteKoe merged 3 commits intoJul 1, 2026
Merged
Conversation
SteKoe
force-pushed
the
test-add-regression-tests-for-uicontroller
branch
from
905af6a to
ca7072b
Compare
SteKoe
changed the title
SteKoe
force-pushed
the
test-add-regression-tests-for-uicontroller
branch
from
ca7072b to
3aff731
Compare
SteKoe
force-pushed
the
test-add-regression-tests-for-uicontroller
branch
from
3aff731 to
89973c4
Compare
ulischulte
pushed a commit
that referenced
this pull request
Jul 3, 2026
Co-authored-by: Stephan Köninger <stephan.koeninger@codecentric.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
I added two regression tests for
UiControlleraround UI model rendering.Impact on coverage:
UiControllermodel and view rendering logic, including covered lines for public URL handling and covered lines for user and view model rendering.UiController.Why:
While looking through the
UiControllerimplementation, I noticed this behavior wasn't directly verified by the existing test suite. These tests verify the UI model produced for anonymous login requests and authenticated stylesheet requests, including public URL handling, UI settings, user details, and filtering of CSS and JavaScript extensions.The change follows the existing Java test style and does not touch client-side files.
Thanks,
Amir