Skip to content

test(expo): Isolate native token bootstrap in sync tests#9039

Merged
wobsoriano merged 1 commit into
mainfrom
rob/fix-flaky-expo-test-part-2
Jun 30, 2026
Merged

test(expo): Isolate native token bootstrap in sync tests#9039
wobsoriano merged 1 commit into
mainfrom
rob/fix-flaky-expo-test-part-2

Conversation

@wobsoriano

@wobsoriano wobsoriano commented Jun 29, 2026

Copy link
Copy Markdown
Member

Description

The native client sync tests in Expo were all starting with getClientToken() returning a device token by default. That meant tests which were trying to verify event handling could also get an unrelated bootstrap token write in the background.

This changes the default mock to return null and keeps the native token setup only in the tests that are actually covering recovery from a native token.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests

    • Updated native client sync test coverage to better reflect token-clearing behavior and resource reload flow.
    • Simplified shared test setup and tightened expectations around device token handling.
  • Chores

    • Added a new changeset entry for release tracking.

@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: aad955c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jun 29, 2026 11:18pm
swingset Ready Ready Preview, Comment Jun 29, 2026 11:18pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: bcf6e305-45fd-44ac-b295-183104535425

📥 Commits

Reviewing files that changed from the base of the PR and between 07e1b06 and aad955c.

📒 Files selected for processing (2)
  • .changeset/stable-expo-native-sync-tests.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx

📝 Walkthrough

Walkthrough

The suite-level beforeEach default for mocks.getClientToken is changed from 'native-client-token' to null, removing the need for per-test mockResolvedValue(null) overrides across ten tests. One waitFor assertion for __internal_reloadInitialResources is removed and mocks.tokenCache.getToken is explicitly set to null in one test. A changeset file is added.

Native-client sync test mock consolidation

Layer / File(s) Summary
Shared default and per-test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx, .changeset/stable-expo-native-sync-tests.md
beforeEach now resolves getClientToken to null; ten individual tests drop their redundant mockResolvedValue(null) lines. In the "native clears the device token" test, tokenCache.getToken is explicitly nulled and the waitFor(__internal_reloadInitialResources) assertion is removed. Changeset entry added.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • clerk/javascript#9016: Modifies the same "reloads JS resources after native clears the device token" test around __internal_reloadInitialResources and deviceToken: null handling.
  • clerk/javascript#9033: Adjusts the same suite's mocks.getClientToken defaults and overrides in the native-client sync echo test scenarios.
  • clerk/javascript#8929: Introduces the syncClientStateFromJs contract that the test mock shapes in this PR are aligned against.

Suggested reviewers

  • mikepitre

🐇 Null is the default, no need to repeat,
Ten mock overrides gone — how neat!
The beforeEach sets the tone,
Each test need not moan alone.
Less code, same truth — a bunny feat! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: isolating native token bootstrap behavior in sync tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jun 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9039

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9039

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9039

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9039

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9039

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9039

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9039

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9039

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9039

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9039

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9039

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9039

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9039

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9039

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9039

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9039

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9039

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9039

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9039

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9039

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9039

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9039

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9039

commit: aad955c

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-29T23:21:07.365Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on aad955c.

@wobsoriano wobsoriano merged commit e9a09f8 into main Jun 30, 2026
59 checks passed
@wobsoriano wobsoriano deleted the rob/fix-flaky-expo-test-part-2 branch June 30, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants