chore: gitignore .env files#1322
Merged
Merged
Conversation
The repository is public and the root `.env` was untracked but matched no ignore rule, so it showed up in `git status` and any `git add .` or `git add -A` would have staged it — publishing whatever it holds to the repo and every fork. It has never been committed to any ref, so this is prevention rather than a leak; nothing needs rotating. `.env.*` subsumes the old `examples/test-app/.env.local` entry, which was the only dotenv rule here and covered a single path. The rules match basenames at any depth, so every variant is now covered wherever it appears. `!.env.example` keeps templates trackable; none exist today, but the negation is what makes the broad `.env.*` safe to add.
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository is public and the root
.envwas untracked but matched no ignore rule. It showed up ingit status, so anygit add .orgit add -Awould have staged it — publishing whatever it holds to the repo and every fork.It has never been committed to any ref (
git log --all --oneline -- .envis empty), so this is prevention rather than a leak. Nothing needs rotating.What changed
.env.*subsumes the oldexamples/test-app/.env.localentry — the only dotenv rule in the file, covering exactly one path. Gitignore matches basenames at any depth, so every variant is now covered wherever it appears.!.env.examplekeeps templates trackable; none exist today, but that negation is what makes the broad.env.*safe.Verified
Removing the
examples/test-app/.env.localline is only safe if.env.*really does cover it, so I checked rather than assumed:.env,examples/test-app/.env.env.local,.env.production.localexamples/test-app/.env.local(the removed rule)website/.env.local.env.examplesrc/utils/env-map.ts,src/platforms/linux/linux-env.tsgit ls-files | git check-ignore --stdinreturns nothing, so no tracked file becomes ignored by this change.Found while preparing #1321, and deliberately kept out of it — that PR staged explicit paths so
.envwas never at risk there.