Update annotation processor to handle GC refs (#70)#83
Merged
Conversation
- listOfValueTypes() handles all abstract heap types and concrete typed refs - Multi-return with object refs for imports now works (was UnsupportedOperationException) - HostFunction.Builder with withRefsHandle() replaces anonymous WasmFunctionHandle boilerplate - Host-function import validation uses ValType.matches() for structural comparison - Integration test covers all permutations of primitives and GC refs in params/returns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70
Testing it with JavaC+WebImage breaks as the exported functions are 14K, but for normal use-cases this should be enough.
FYI @RefuX