Allow empty strings as import names for function imports#82
Merged
andreaTP merged 2 commits intoJul 6, 2026
Merged
Conversation
…d by the import kind byte validation Also fix import/export kind to be read as a single byte per the spec binary format, not as LEB128. Overlong LEB128 encodings like 0x80 0x00 were incorrectly accepted as valid kind values.
andreaTP
force-pushed
the
fix/allow-empty-import-names
branch
from
ff30213 to
66804b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebAssembly spec permits empty names (zero-length UTF-8 strings) as valid import module and field names. The removed check incorrectly rejected function imports when both names were empty, while other import types (table, memory, global, tag) already accepted them.
Big reported here: roastedroot/endive-cm#15 (comment)
This was a leftover from an earlier iteration of the
binary.wastmalformed import kind handling, the check got moved into theFUNCTIONcase but was never removed when the properbyId()catch was added.