Skip to content

feat(mongodb): accept string arguments in Int32/NumberInt helpers #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebelice merged 1 commit into from
Mar 24, 2026
Merged

feat(mongodb): accept string arguments in Int32/NumberInt helpers #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mongodb/MongoShellParser.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,9 +819,9 @@ longHelper
: (LONG | NUMBER_LONG) LPAREN (NUMBER | stringLiteral) RPAREN
;

// Int32(n), NumberInt(n)
// Int32(n), Int32("n"), NumberInt(n), NumberInt("n")
int32Helper
: (INT32 | NUMBER_INT) LPAREN NUMBER RPAREN
: (INT32 | NUMBER_INT) LPAREN (NUMBER | stringLiteral) RPAREN
Comment on lines +822 to +824

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grammar now accepts Int32("n") / NumberInt("n"), but the parser test suite (driven by mongodb/examples/*.js) currently only exercises numeric Int32(100) / NumberInt(100). Please add examples for the quoted-string forms (e.g., in examples/helper_functions.js) so this new syntax is covered and regressions are caught.

Copilot uses AI. Check for mistakes.
;

// Double(n)
Expand Down
Loading
Loading