feat: display the network type on the home screen#62
Open
skypank-coder wants to merge 1 commit into
Open
Conversation
The label under the balance was hardcoded to BITCOIN. Thread the wallet's network through WalletScreenState and render it (SIGNET BITCOIN, REGTEST BITCOIN, etc.) so it's clear which network the wallet is on. Closes bitcoindevkit#59
Author
|
@thunderbiscuit Please Review this . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The label under the balance was hardcoded to "BITCOIN", which is misleading
on any wallet that isn't on mainnet.
This threads the wallet's network through
WalletScreenState(seeded fromwallet.networkwhen the view model builds its initial state) and renders itunder the balance, so the home screen reads "SIGNET BITCOIN", "REGTEST BITCOIN",
and so on.
Closes #59