bump bdk message signer#301
Open
aagbotemi wants to merge 3 commits into
Open
Conversation
- bump bdk_wallet to 3.1.0
- replace Network with NetworkKind
- replace TxBuilder::include_output_redeem_witness_script with TxBuilder::add_global_xpubs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 56.89% 57.02% +0.12%
==========================================
Files 22 22
Lines 3661 3653 -8
==========================================
Hits 2083 2083
+ Misses 1578 1570 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the BIP-322 message signing integration from
bdk_bip3220.1.0 tobdk_message_signer0.2.0, and bumpsbdk_walletfrom 2.4.0 to 3.1.0.Notes to the reviewers
The
bdk_walletbump is included here out of necessity,bdk_message_signer0.2.0 implements its signing traits forbdk_wallet3.x'sWallettype. With the CLI on 2.4.0, cargo resolves two incompatible copies ofbdk_walletand the sign/verify methods don't exist on the CLI's wallet (as at the point of creating this PR), so the feature cannot compile without the bump.Changelog notice
bdk_bip322dependency withbdk_message_signer0.2.0bdk_walletto 3.1.0 and fix the resulting breakage.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.mdBugfixes: