feat(BBBInput): add labeled text field with inline action button#56
Open
Arthurk12 wants to merge 2 commits into
Open
feat(BBBInput): add labeled text field with inline action button#56Arthurk12 wants to merge 2 commits into
Arthurk12 wants to merge 2 commits into
Conversation
Adds a new BBBInput component unifying the recurring "text field + submit button" pattern found ad hoc in chat, guest messages and breakouts (issue bigbluebutton#34): an auto-growing textarea with a labeled action button, submit-on-Enter, controlled/uncontrolled value handling matching BBBSearch, an opt-in "sent" feedback affordance, and beforeButton/afterButton slots for extra actions (e.g. an emoji picker) next to the submit button. Registers the component across the package's export surface (components index, webpack entries, package.json exports/typesVersions, root README) following the existing per-component conventions.
…it button The existing layouts don't fit a compact icon-only button next to a single line of text: circle/stacked are fixed-size boxes (3rem/4.5rem) that make the row taller than the text line dictates, and default layout's border-radius reads as nearly round at small sizes. squared is icon-only, sized by its own equal padding (not a fixed box), with a smaller border radius so it reads as squared rather than round — matching the real chat input's send button shape, which BBBInput now uses by default for icon-only submissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new BBBInput component unifying the recurring "text field + submit button" pattern found ad hoc in chat, guest messages and breakouts (issue #34): an auto-growing textarea with a labeled action button, submit-on-Enter, controlled/uncontrolled value handling matching BBBSearch, an opt-in "sent" feedback affordance, and beforeButton/afterButton slots for extra actions (e.g. an emoji picker) next to the submit button.
Registers the component across the package's export surface (components index, webpack entries, package.json exports/typesVersions, root README) following the existing per-component conventions.
Closes Issue(s)
Closes #34