Add BatchWriteRecord and ListRecod apis to Sagemaker Feature Store Runtime#5983
Open
BassemHalim wants to merge 1 commit into
Open
Add BatchWriteRecord and ListRecod apis to Sagemaker Feature Store Runtime#5983BassemHalim wants to merge 1 commit into
BassemHalim wants to merge 1 commit into
Conversation
…roup Add two new FeatureStore Runtime operations to the FeatureGroup resource: - batch_write_record: writes a batch of records to one or more FeatureGroups - list_records: lists RecordIdentifier values stored in a FeatureGroup's OnlineStore Changes: - Update service-2.json from botocore 1.43.38 - Add shape classes (BatchWriteRecordEntry, BatchWriteRecordResponse, etc.) - Add shape_dag entries and additional_operations mapping - Add exclude_resource_attributes support to codegen to prevent FeatureGroup.next_token from being incorrectly mapped to ListRecords.NextToken (different pagination contexts) - Regenerate resources.py and shapes.py via codegen --- X-AI-Prompt: add batch_write_record and list_records to sagemaker-core FeatureGroup, fix codegen next_token bug X-AI-Tool: kiro-cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
BatchWriteRecordandListRecordsFeatureStore Runtime operations to theFeatureGroupresource class.Changes
service-2.json: Updated from botocore 1.43.38 (addsBatchWriteRecord,ListRecordsoperations and related shapes)additional_operations.json: Maps new operations toFeatureGroupresource withexclude_resource_attributesforListRecordsshape_dag.py: Adds DAG entries for new shapes (BatchWriteRecordEntry,BatchWriteRecordResponse,ListRecordsRequest, etc.)resources_codegen.py: Addsexclude_resource_attributessupport to prevent incorrect self-mapping when a resource attribute name collides with an unrelated operation inputresources.py(generated): Newbatch_write_record()andlist_records()methods onFeatureGroupshapes.py(generated): New shape classes forBatchWriteRecord/ListRecordsrequest/response typestest_feature_store_operations.py: Unit tests covering both methods, pagination, and nested response deserializationCodegen Fix:
exclude_resource_attributesThe codegen maps API input fields to
self.<attr>when the field name matches a resource class attribute. This caused a bug:ListRecords.NextTokenwas mapped toself.next_token, which is theDescribeFeatureGrouppagination token (forFeatureDefinitions) — a completely different pagination context.The fix adds an
exclude_resource_attributesfield toadditional_operations.jsonthat prevents specific resource attributes from being auto-mapped, making them regular method parameters instead.Testing
FeatureGroupin us-west-2 (not included in this PR)