Skip to content

Add HTTP alternate quality AuTest#13391

Open
bneradt wants to merge 1 commit into
apache:masterfrom
bneradt:http-alt-info-quality-autest
Open

Add HTTP alternate quality AuTest#13391
bneradt wants to merge 1 commit into
apache:masterfrom
bneradt:http-alt-info-quality-autest

Conversation

@bneradt

@bneradt bneradt commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

This adds an AuTest to verify the TSHttpAltInfoQualitySet plugin API.
The test verifies alternate creation and selection through observable
cached responses.

Closes: #7205

Copilot AI review requested due to automatic review settings July 15, 2026 22:59
@bneradt bneradt added this to the 11.0.0 milestone Jul 15, 2026
@bneradt bneradt self-assigned this Jul 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an AuTest that makes the effect of TSHttpAltInfoQualitySet() observable by validating which cached alternate is selected during cache lookup, addressing the gap described in #7205.

Changes:

  • Add a dedicated AuTest plugin (http_alt_info_quality) that assigns alternate “quality” by comparing client vs cached request query strings.
  • Add a new replay-driven cache test that stores multiple alternates and asserts the selected cached response via response headers.
  • Wire the plugin into the AuTest build and test harness.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/tools/plugins/http_alt_info_quality.cc New AuTest plugin that sets alternate quality based on query-string equality.
tests/tools/plugins/CMakeLists.txt Builds the new AuTest plugin.
tests/gold_tests/cache/replay/alternate-caching-quality.yaml New replay scenario asserting alternate creation/selection behavior.
tests/gold_tests/cache/alternate-caching.test.py Runs the new replay and loads the new test plugin for the ATS process.

Comment thread tests/gold_tests/cache/replay/alternate-caching-quality.yaml Outdated
@bneradt
bneradt force-pushed the http-alt-info-quality-autest branch 2 times, most recently from 35c1f6a to 2ba9ee4 Compare July 15, 2026 23:24
Copilot AI review requested due to automatic review settings July 15, 2026 23:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread tests/tools/plugins/http_alt_info_quality.cc Outdated
Comment thread tests/tools/plugins/http_alt_info_quality.cc Outdated
This adds an AuTest to verify the TSHttpAltInfoQualitySet plugin API.
The test verifies alternate creation and selection through observable
cached responses.

Closes: apache#7205
Copilot AI review requested due to automatic review settings July 16, 2026 13:26
@bneradt
bneradt force-pushed the http-alt-info-quality-autest branch from 2ba9ee4 to 857eae2 Compare July 16, 2026 13:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status
Status: No status

Development

Successfully merging this pull request may close these issues.

The TS API function TSHttpAltInfoQualitySet() does not appear to have any effect.

2 participants