test(frontend): cover isSink and isPythonUdf helpers#6675
Conversation
Automated Reviewer SuggestionsBased on the
|
There was a problem hiding this comment.
Pull request overview
This PR adds frontend unit test coverage for two helper functions (isSink and isPythonUdf) in the workflow graph model, improving confidence in operator-type classification behavior used by the workflow editor.
Changes:
- Added unit tests for
isSinkcovering substring matching, case-insensitivity, and non-matching operator types. - Added unit tests for
isPythonUdfcovering all supported Python UDF v2 operator types plus negative cases. - Updated imports in
workflow-graph.spec.tsto reference the helper functions and related operator-type constants.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Merged main to trigger coverage report. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6675 +/- ##
============================================
- Coverage 77.31% 76.65% -0.66%
+ Complexity 3524 3452 -72
============================================
Files 1161 1161
Lines 45920 45916 -4
Branches 5099 5098 -1
============================================
- Hits 35501 35198 -303
- Misses 8839 9183 +344
+ Partials 1580 1535 -45
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Closing as it doesn't increase coverage: #6675 (comment) |
|
Will reevaluate after fixing the Codecov Report. |
What changes were proposed in this PR?
Any related issues, documentation, discussions?
Closes: #6674
How was this PR tested?
cd frontend && node --max-old-space-size=8192 ./node_modules/nx/dist/bin/nx.js test gui --watch=false --include=src/app/workspace/service/workflow-graph/model/workflow-graph.spec.ts, expect the suite passing.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF