replacing StringBuilder with StringJoiner in order to simplify logic#4628
Open
renatoh wants to merge 6 commits into
Open
replacing StringBuilder with StringJoiner in order to simplify logic#4628renatoh wants to merge 6 commits into
renatoh wants to merge 6 commits into
Conversation
chan-dx
reviewed
Jul 23, 2026
chan-dx
reviewed
Jul 23, 2026
…t.java Co-authored-by: Chan Chan <chan.dx.dev@gmail.com>
epugh
reviewed
Jul 23, 2026
| final StringBuilder sb = new StringBuilder(128); | ||
| boolean first = true; | ||
|
|
||
| var output = new StringJoiner("&", "?", ""); |
Contributor
There was a problem hiding this comment.
interesting pattern, I've never seen StringJoiner before.
Contributor
Author
There was a problem hiding this comment.
Hi @epugh, it has been around for a while, since Java 8, but I have only discovered it recently and since then I have been using it quite frequently, it saves you exactly those isFirst checks.
Contributor
|
I marked it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@janhoy
Following up on the discussion on #4606, I simplified the creation of URLs by moving from StringBuilder to the more flexible StringJoiner.
I had to change the signature of the public method StrUtils.partialURLEncodeVal, since it was couple to a StringBuilder, now it returns the encodedUrl rather than adding it to the passed in StringBuilder, which is more flexible.
Not sure if I can just change the signature of such a method or if I need to keep old method.