Collections.Iterable Update to support Python 3.10#1165
Closed
fengints wants to merge 3 commits into
Closed
Conversation
Replace Collections with collections.abc for Iterable
fengints
changed the title
Contributor
|
solved |
Contributor
|
solved |
Author
|
@lzjpaul my 2y ago issue(pr), well at least someone took care of it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referring to this issue
#1164
Iterable class exists in collections.abc since Python 3.3.
https://docs.python.org/3.3/library/collections.abc.html#collections.abc.Iterable
Replaced all collections.Iterable with collections.abs.Iterable in project except this one, someone made it this way
singa/examples/model_selection/Trails/singa_pkg_code/model.py
Lines 32 to 35 in 6d9cd7f