fix(blob): support unknown-length BlobDescriptor ranges#521
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
Dedicated blob writers cast descriptor lengths to u64, while inline resolvers rejected negative lengths. This broke valid Java descriptors with length -1. Treat -1 as offset-to-EOF in both paths, validate ranges, and reject short reads before they can produce inconsistent blob data. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
BlobDescriptor.length == -1means reading fromoffsetto EOF. The dedicated BLOB writer cast this value tou64, while theblob-descriptor-fieldresolver rejected it as negative, causing inconsistent behavior across table configurations.Brief change log
length == -1in both dedicated BLOB writes and inline descriptor reads.Tests
cargo test -p paimon --all-targets --features fulltext,vortexcargo test -p paimon-datafusion --test blob_testsAPI and Format
No API or storage format change. This implements the existing BlobDescriptor protocol semantics.
Documentation
Documented the
length == -1behavior and range constraints.