Skip to content

Fix Omni pytest#263

Open
MonkeyCanCode wants to merge 1 commit into
apache:mainfrom
MonkeyCanCode:fix_omni_pytest
Open

Fix Omni pytest#263
MonkeyCanCode wants to merge 1 commit into
apache:mainfrom
MonkeyCanCode:fix_omni_pytest

Conversation

@MonkeyCanCode

Copy link
Copy Markdown
Contributor

Summary

This is sample fix for #260. There are two issues introduced by #113:

  1. the new datatype field caused test_tpcds_export_matches_expected to fail due to Omni exporter lacks the logic to default is_time: true for temporal-typed fields whose explicit dimension role was unset
  2. the test_osi_roundtrip_up_to_documented_normalizations fails due to non-native datatype property is dropped upon export but the test's normalization helper didn't remove it from the compared semantic model.

Related Issues

Checklist

Specification

  • Spec changes are included in core-spec/ and follow the existing structure
  • Spec changes have been discussed on the mailing list or in a linked issue
  • Breaking changes to the spec are clearly called out in the summary

Ontology

  • Ontology changes in ontology/ are consistent with spec changes
  • New or modified terms are defined and documented

Converters

  • Converter logic in converters/ is updated to reflect spec or ontology changes
  • New converters include tests under the converter's test directory

Validation

  • Validation rules in validation/ are updated if the spec changed
  • New validation cases are covered by tests

Documentation

  • docs/ is updated to reflect any user-facing changes
  • New features or behaviors are documented with examples where appropriate
  • CONTRIBUTING.md is updated if the contribution process changed

Examples

  • examples/ are added or updated for any new spec constructs or converter support

Tests

  • All existing tests pass (pytest / CI green)
  • New functionality is covered by tests

Compliance

  • ASF license headers are present on all new source files
  • No third-party dependencies are added without PMC/IPMC approval

@wForget

wForget commented Jul 27, 2026

Copy link
Copy Markdown
Member

Should we also trigger converter-omni-ci when there are changes to core-spec/ or examples/?

@MonkeyCanCode

Copy link
Copy Markdown
Contributor Author

Should we also trigger converter-omni-ci when there are changes to core-spec/ or examples/?

For this specific one, I think it should be trigger on python/src/ossie as core-spec/ doesn't directly get used by the converters. Now for examples, not everything uses examples as direct references, thus, I am not sure if that would be a good idea for apply for all (but for sure we can apply for this specific one). However, maybe we should raise those up in a different PR? The original problem with 113 got merged was no CI was ran as it didn't rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants