Skip to content

Docs: Remove stale reference to closed #2152 in streaming write docstrings #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qzyu999 wants to merge 1 commit into from
+5 −9
Closed

Docs: Remove stale reference to closed #2152 in streaming write docstrings #3597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pyiceberg/io/pyarrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2881,8 +2881,7 @@ def _dataframe_to_data_files(
For a ``pa.RecordBatchReader`` batches are streamed and microbatched into
target-sized files using bounded memory (see :func:`bin_pack_record_batches`).
Streaming writes are currently only supported on unpartitioned tables;
partitioned support is tracked in
https://github.com/apache/iceberg-python/issues/2152.
partitioned streaming support is not yet implemented.

Returns:
An iterable that supplies datafiles that represent the input data.
Expand All @@ -2909,8 +2908,7 @@ def _dataframe_to_data_files(
if not table_metadata.spec().is_unpartitioned():
raise NotImplementedError(
"Writing a pa.RecordBatchReader to a partitioned table is not yet supported. "
"Materialise the reader as a pa.Table first, or follow "
"https://github.com/apache/iceberg-python/issues/2152 for partitioned streaming support."
"Materialise the reader as a pa.Table first."
)
yield from write_file(
io=io,
Expand Down
6 changes: 2 additions & 4 deletions pyiceberg/table/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,8 +473,7 @@ def append(

Streaming writes are currently only supported on unpartitioned tables;
passing a ``pa.RecordBatchReader`` for a partitioned table raises
``NotImplementedError``. See
https://github.com/apache/iceberg-python/issues/2152.
``NotImplementedError``.

Note:
When ``df`` is a ``pa.RecordBatchReader`` the reader is consumed
Expand Down Expand Up @@ -621,8 +620,7 @@ def overwrite(

Streaming writes are currently only supported on unpartitioned tables;
passing a ``pa.RecordBatchReader`` for a partitioned table raises
``NotImplementedError``. See
https://github.com/apache/iceberg-python/issues/2152.
``NotImplementedError``.

Note:
When ``df`` is a ``pa.RecordBatchReader`` the reader is consumed
Expand Down
2 changes: 1 addition & 1 deletion tests/catalog/test_catalog_behaviors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,7 +1216,7 @@ def test_drop_namespace_raises_error_when_namespace_not_empty(
# RecordBatchReader streaming append/overwrite tests
#
# Streaming writes accept a pa.RecordBatchReader and microbatch it into target-sized
# Parquet files instead of materialising the full Arrow Table in memory. Tracks
# Parquet files instead of materialising the full Arrow Table in memory. Introduced in
# https://github.com/apache/iceberg-python/issues/2152.


Expand Down