feat: native RANGE window frames with explicit offset on " DECIMAL " ORDER BY#4987
Open
0lai0 wants to merge 2 commits into
Open
feat: native RANGE window frames with explicit offset on " DECIMAL " ORDER BY#49870lai0 wants to merge 2 commits into
0lai0 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4834 (DECIMAL ORDER BY only; DATE is handled in #4974)
Rationale for this change
Native windows used to fall back to Spark for
RANGEframes with an explicitPRECEDING/FOLLOWINGoffset whenORDER BYwasDECIMAL. The original reason was that Spark decimal arithmetic widens precision on+/-, so the computed boundary (e.g.Decimal(11,0)) no longer matched the current value's precision (e.g.Decimal(10,0)) and DataFusion's comparator failed with "Uncomparable values".That mismatch was fixed upstream in apache/datafusion#22174 (closes #22113):
ScalarValue::partial_cmpnow ignores precision forDecimal128when the scales match. The fix ships in DataFusion 54.0.0, which Comet already pins, so DECIMALRANGEboundary arithmetic runs correctly on the native side with no planner changes needed. This PR just removes the now-stale Scala fallback.UNBOUNDED/CURRENT ROWalready ran natively; DATE still falls back.What changes are included in this PR?
DecimalTypeRANGEfallback; keep the DATE fallback.RANGEfallback list inoperators.md/roadmap.md, and document aDecimal128near-max-precision overflow difference under "Known differences".CometWindowExecSuite(bounds combinations, duplicate values, nulls, DESC ordering, zero scale, high precision/scale, negative values crossing zero, fractional offset,DECIMAL(38,0)max precision).How are these changes tested?