You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Converter.DATE parses with a default-locale SimpleDateFormat, but its documented input (the output of Date.toString()) always uses English month and day names, so a Date-typed option throws ParseException under any non-English default locale; pinning Locale.ENGLISH keeps the documented round-trip stable, which is also why testCreateDate already needed a @DefaultLocale pin.
garydgregory
changed the title
use Locale.ENGLISH when parsing dates in Converter.DATE
Use Locale.ENGLISH when parsing dates in Converter.DATE
Jun 27, 2026
The reason will be displayed to describe this comment to others. Learn more.
Hello @rootvector2
How do you avoid breaking existing apps? Try to parse it twice? Rebase on git master and see the new test: org.apache.commons.cli.ConverterTests.testDateLocaleDe()
Rebased on master. You're right that pinning Locale.ENGLISH outright would break testDateLocaleDe and any app passing a default-locale string, so I went with the parse-twice route: Converter.DATE now parses with the default locale first and only falls back to Locale.ENGLISH when that throws. Anything that parses today hits the exact same first parse, so existing behavior is unchanged; the fallback only covers the Date.toString() output, which is always English regardless of locale. Added testDateLocaleDeEnglishInput to lock that path under a de default. Both it and your testDateLocaleDe pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converter.DATEparses with a default-localeSimpleDateFormat, but its documented input (the output ofDate.toString()) always uses English month and day names, so aDate-typed option throwsParseExceptionunder any non-English default locale; pinningLocale.ENGLISHkeeps the documented round-trip stable, which is also whytestCreateDatealready needed a@DefaultLocalepin.