refactor(bvar): replace NULL with nullptr#3403
Merged
Merged
Conversation
Modernize pointer null literals across bvar sources for C++11 consistency, including pthread APIs and related comments.
Contributor
|
Nice job! I previously submitted a PR (#2786) to refactor all NULL values in the project into nullptr. However, the change was too significant, so it wasn't merged. I think it could be split into multiple PRs for the refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve N/A
Problem Summary:
src/bvarstill used the legacyNULLmacro for pointer null values. Since bRPC already builds with at least C++11, usingnullptris clearer and type-safe, especially in overloaded calls and pointer comparisons.What is changed and the side effects?
Changed:
NULLwithnullptracrosssrc/bvarheaders and implementation files.NULL.Side effects:
Performance effects: None expected. This is a source-level modernization with no intended runtime behavior change.
Breaking backward compatibility: No.
nullptris available under the project’s C++11 baseline.Check List:
cmake --build build --target brpc-static -j6.git diff --check.NULLtokens remain insrc/bvarviarg '\bNULL\b' src/bvar -g '*.{h,cpp}'.