Administration: Prevent PHP deprecation notice in get_admin_page_title()#12590
Administration: Prevent PHP deprecation notice in get_admin_page_title()#12590ikamal7 wants to merge 1 commit into
Conversation
…e(). When calling get_admin_page_title() on admin pages where the global $plugin_page is null (such as Tools, Plugins, etc.), PHP 8.1 triggers a deprecation notice because null is passed to get_plugin_page_hook() which passes it to preg_replace() via get_plugin_page_hookname(). While the function correctly handles null via isset() checks later, the initial call to get_plugin_page_hook() passed null directly. Adding an early type guard ensures $plugin_page is always a string before being passed down the call chain. Props hellofromTonya for the suggested approach. Fixes #59365.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
Prevents a PHP 8.1+ deprecation notice when calling
get_admin_page_title()on admin pages where the global$plugin_pageis null (e.g., Tools, Plugins pages).Trac ticket: https://core.trac.wordpress.org/ticket/59365
Changes:
get_admin_page_title()to ensure$plugin_pageis a string before passing it toget_plugin_page_hook()