Skip to content

Media: Set HEIC upload support flag (65648)#12589

Open
wprashed wants to merge 1 commit into
WordPress:trunkfrom
wprashed:fix-heic-upload-support
Open

Media: Set HEIC upload support flag (65648)#12589
wprashed wants to merge 1 commit into
WordPress:trunkfrom
wprashed:fix-heic-upload-support

Conversation

@wprashed

Copy link
Copy Markdown

Summary
Adds the window.__heicUploadSupport flag when client-side media processing is enabled, allowing the block editor’s HEIC canvas fallback to run in browsers such as Safari.
Why
Core already sets window.__clientSideMediaProcessing, but the HEIC-only canvas fallback is gated behind window.__heicUploadSupport. Without this flag, Safari skips client-side HEIC conversion and uploads HEIC files as-is, leaving conversion entirely to server-side image processing.
Changes
Sets window.__heicUploadSupport = true; in wp_set_client_side_media_processing_flag().
Adds PHPUnit coverage for:non-Chromium browsers such as Safari
Chromium 137+ browsers
disabled wp_client_side_media_processing_enabled filter

Testing
php -l src/wp-includes/media.php
php -l tests/phpunit/tests/media/wpSetClientSideMediaProcessingFlag.php
Targeted PHPUnit could not be run locally because the environment is missing project dependencies: dotenv for the npm test runner and no local vendor/ PHPUnit binary.
Trac ticket: https://core.trac.wordpress.org/ticket/65648

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wprashed.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant