#65591 - About Page - 7.0.1 Release#12442
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| <a href="contribute.php" class="nav-tab"><?php _e( 'Get Involved' ); ?></a> | ||
| </nav> | ||
|
|
||
| <div class="about__section changelog has-subtle-background-color"> |
There was a problem hiding this comment.
| <div class="about__section changelog has-subtle-background-color"> | |
| <div class="about__section has-subtle-background-color"> |
I don't think we need an extra class here.
There was a problem hiding this comment.
@mukeshpanchal27 not sure about the background of changelog but it has already been there in 6.9 so i took it over as well, see https://github.com/WordPress/wordpress-develop/blob/6.9/src/wp-admin/about.php#L63
There was a problem hiding this comment.
I don't see any CSS or usage of that class also don't know the history why it was added 🤔
| __( 'For more information, see <a href="%s">the release notes</a>.' ), | ||
| sprintf( | ||
| /* translators: %s: WordPress version. */ | ||
| esc_url( __( 'https://wordpress.org/support/wordpress-version/version-%s/' ) ), |
There was a problem hiding this comment.
It looks like this URL now redirect to the documentation site (https://wordpress.org/documentation/wordpress-version/version-*).
Should we update it to point to the correct location?
There was a problem hiding this comment.
Same this has been also in the 6.9.4 release done like this, see: https://github.com/WordPress/wordpress-develop/blob/6.9/src/wp-admin/about.php#L80C22-L80C81
That would lead to this doc: https://wordpress.org/documentation/wordpress-version/version-6.9.4/
There was a problem hiding this comment.
I think this should be updated for new versions, as it will eventually redirect to the Documentation site rather than the Support site.
I'd prefer to update it sooner rather than later so we don't end up with future tickets for the same issue.
If this needs more discussion before making the change, I'm happy to open a separate ticket.
WDYT?
2 participants
Add the about.php page for the WordPress 7.0.1 Maintenance Release.
Trac ticket: https://core.trac.wordpress.org/ticket/65591
Use of AI Tools
none.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.