Remove jQuery in the frontend for Twenty Twelve.#12411
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @felixarntz@google.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
- Iterate HTMLCollection with a for loop in getSiblingElements() and use querySelectorAll() for menu links, as HTMLCollection has no forEach and both calls threw a TypeError, breaking the whole script. - Restore the negated focus check in the touchstart handler so the first tap on a parent menu item opens the submenu instead of navigating immediately, matching the original jQuery behavior. - Drop the duplicate per-link touchstart listeners in favor of the single delegated handler, which also covers dynamically added items. - Register the delegated touchstart listener as non-passive so preventDefault() works; browsers default to passive touch listeners on body.
|
Merged the latest trunk (clean, no conflicts) and fixed several runtime bugs found while re-reviewing the vanilla JS against the original review feedback on #1683:
Verified in a browser harness: menu toggle updates |
Refreshed version of #1683 (the original branch lives on a fork that can no longer be updated), merged with current trunk. Trunk changes since the original PR - the deferred loading strategy for
twentytwelve-navigationand thearia-expandedtoggling on the menu button - are preserved in the vanilla JS implementation.Trac ticket: https://core.trac.wordpress.org/ticket/54171