Remove jQuery in the frontend for Twenty Fifteen.#12410
Remove jQuery in the frontend for Twenty Fifteen.#12410adamsilverstein wants to merge 9 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @felixarntz@google.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
- Fix always-true condition in the secondary toggle click handler: classList.contains() returns a boolean, so comparing against -1 meant aria-expanded was always set to 'true', even when closing the sidebar. - Replace getElementsByTagName().forEach() with querySelectorAll(), as HTMLCollection has no forEach and the call threw a TypeError. - Guard onResizeARIA and resizeAndScroll against missing elements to preserve the null-tolerance the previous jQuery code provided. - Use a string value for the sidebar bottom style.
|
Merged the latest trunk (clean, no conflicts) and fixed two runtime bugs found while re-reviewing the vanilla JS against the original review feedback on #1682:
Also added null guards in Verified in a browser harness: dropdown toggles update |
Refreshed version of #1682 (the original branch lives on a fork that can no longer be updated), merged with current trunk. Trunk changes since the original PR - the deferred loading strategy for
twentyfifteen-scriptand thearia-expandedaccessibility improvements in the menu toggles - are preserved in the vanilla JS implementation.Trac ticket: https://core.trac.wordpress.org/ticket/54172