Connectors: Preserve stored AI provider API key when validation is indeterminate#12345
Conversation
…determinate. `_wp_connectors_rest_settings_dispatch()` discarded a stored AI provider API key whenever validation did not return strictly `true`. Since `_wp_connectors_is_ai_api_key_valid()` returns `null` when a key cannot be verified, a transient provider outage during a settings save permanently wiped a valid key. Only discard the key on an explicit `false` result so that an unverifiable key is preserved. Adds coverage for the dispatch handler. Props itzmekhokan. See #65551.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
Summary
_wp_connectors_rest_settings_dispatch()discarded a stored AI provider API key whenever validation did not return strictlytrue. Since_wp_connectors_is_ai_api_key_valid()returnsnullwhen a key cannot be verified (e.g. the provider is temporarily unreachable), a transient outage during a settings save permanently wiped a valid key.This changes the check to only discard on an explicit
falseresult. Any other result preserves the stored key.Changes
src/wp-includes/connectors.php: discard the key only on an explicitfalsefrom_wp_connectors_is_ai_api_key_valid().tests/phpunit/tests/connectors/wpConnectorsRestSettingsDispatch.php: new coverage for the dispatch handler — indeterminate preserves, invalid discards, valid preserved + masked, GET is a no-op.Testing
phpunit --group connectors→ 85 tests, 219 assertions, passing.test_indeterminate_validation_preserves_key, confirming the new test guards the regression.Trac ticket: https://core.trac.wordpress.org/ticket/65551
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 4.8
Used for: Ticket analysis and tests cases. All changes were reviewed, validated against the codebase, and are taken responsibility for by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.